Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine hold-to-select character implementation #5

Closed
andrewtavis opened this issue Nov 22, 2021 · 0 comments · Fixed by #54
Closed

Combine hold-to-select character implementation #5

andrewtavis opened this issue Nov 22, 2021 · 0 comments · Fixed by #54
Assignees
@andrewtavis
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

andrewtavis commented Nov 22, 2021 •
edited
Loading

Hold-to-select characters have been the hardest part of the Scribe UI to implement. One of the issues that would be good for a first time contributor would be to combine all the functions related to in into one. Currently at the bottom of KeyboardViewController.swift there's the function setAlternatesView. This function is followed by a series of functions for each of the keys that can be held to select other options - ex aLongPressedSelectAlternates. This was necessary as it has been difficult to derive which key was being pressed from the sender argument in setAlternatesView. Once that be be derived all of the LongPressedSelectAlternates functions could be combined into one that simply checks which key. This one function would further be set for UILongPressGestureRecognizer for each of the given keys.
@andrewtavis andrewtavis added feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Nov 22, 2021
@andrewtavis andrewtavis changed the title Modularizing hold-to-select character implementation Modularize hold-to-select character implementation Nov 30, 2021
@andrewtavis andrewtavis changed the title Modularize hold-to-select character implementation Combine hold-to-select character implementation Nov 30, 2021
andrewtavis added a commit that referenced this issue Nov 30, 2021
@andrewtavis
#5 Combine all functions for hold-to-select characters
34b6365
andrewtavis added a commit that referenced this issue Nov 30, 2021
@andrewtavis
Merge pull request #54 from scribe-org/combine-hold-to-select-fxns
e4c10a4 
#5 Combine all functions for hold-to-select characters
@andrewtavis andrewtavis linked a pull request Nov 30, 2021 that will close this issue
#5 Combine all functions for hold-to-select characters #54
Merged
andrewtavis added a commit that referenced this issue Jan 30, 2022
@andrewtavis
#2, #4, #5 add new Scribe logo and icon files
e81aff7
@andrewtavis andrewtavis self-assigned this Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewtavis andrewtavis

Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#5 Combine all functions for hold-to-select characters scribe-org/Scribe-iOS
1 participant
@andrewtavis