-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fabuloui os fix swift lint warning closure parameter position 434 new #437
Fabuloui os fix swift lint warning closure parameter position 434 new #437
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
@wkyoshida, I set the new target for the swiftlint workflow for this and the other PR, and tests still pass. Maybe what happened was that the reporting that we'd have such warnings was off? 🤔 |
…fabulouiOS-Fix-swiftLint-warning-closure_parameter_position-434-new
…tion-434-new' of https://github.com/fabulouiOS-monk/Scribe-iOS into fabulouiOS-Fix-swiftLint-warning-closure_parameter_position-434-new
…ameter_position-434-new
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes here, @fabulouiOS-monk! Great to have these improvements moving forward. Let me know if you'd like to join one of our dev syncs sometime. They're Saturdays at 14:00 UTC, with the next one being in two weeks 😊
@andrewtavis, thanks for inviting me to the dev sync. I will surely join it! |
Contributor checklist
Description
Related issue