Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabuloui os fix swift lint warning closure parameter position 434 new #437

Conversation

fabulouiOS-monk
Copy link
Collaborator

@fabulouiOS-monk fabulouiOS-monk commented May 18, 2024

Contributor checklist


Description

Related issue

Copy link

github-actions bot commented May 18, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-iOS repo
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Member

@wkyoshida, I set the new target for the swiftlint workflow for this and the other PR, and tests still pass. Maybe what happened was that the reporting that we'd have such warnings was off? 🤔

@andrewtavis andrewtavis self-requested a review May 18, 2024 04:57
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes here, @fabulouiOS-monk! Great to have these improvements moving forward. Let me know if you'd like to join one of our dev syncs sometime. They're Saturdays at 14:00 UTC, with the next one being in two weeks 😊

@andrewtavis andrewtavis merged commit cfac86e into scribe-org:main May 18, 2024
1 check passed
@fabulouiOS-monk fabulouiOS-monk deleted the fabulouiOS-Fix-swiftLint-warning-closure_parameter_position-434-new branch May 20, 2024 02:37
@fabulouiOS-monk
Copy link
Collaborator Author

@andrewtavis, thanks for inviting me to the dev sync. I will surely join it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants