-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed void_function_in_ternary from disabled rules in .swiftint.yml #444
Removed void_function_in_ternary from disabled rules in .swiftint.yml #444
Conversation
…n .swiftlint.yml
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
Thanks for this, @mostazomarc! I'll try to get to all the new PRs before the end of the weekend :) |
You’re welcome, @andrewtavis! No rush, take your time. Have a great weekend! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, @mostazomarc! 😊 Really appreciate all the support! Would be great to have you join a sync at some point. That's every two Saturdays, with the most recent one being today. Let me know if you'd like the details for that. It's at 14:00 UTC :)
Thanks for the invitation @andrewtavis! I'd love to join a sync. Please share the details for the next meeting. Looking forward to it! |
Sure thing, @mostazomarc! If you join us in the general channel on Matrix that's where the notifications for the sync are that include the notes pad for the week and the call link, or if you'd prefer an email invite feel free to send along an email it should go to to the email in my profile 😊 |
Contributor checklist
Description
Removed
void_function_in_ternary
as a disabled rule from .swiftlint.yml and fixed all errors for it in the codebase.The linter fix was tested running:
swiftlint --no-cache --config ~/com.raywenderlich.swiftlint.yml
and tested on:Related issue