Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the header "keyboard installation" #449

Merged
merged 3 commits into from
May 30, 2024

Conversation

henrikth93
Copy link
Member

Changed the header in the install menu so it says "keyboard installation", and it is now extracted from the white box.

Contributor checklist


Description

Related issue

Changed the header in the install menu so it says "keyboard installation", and it is now extracted from the white box.
@henrikth93 henrikth93 requested a review from andrewtavis May 30, 2024 18:44
Copy link

github-actions bot commented May 30, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-iOS repo
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Fixed trailing whitespace lint errors
"settings.installedKeyboards" : {
"comment" : "The title of the installed keyboards section",
"comment" : "Scribe keyboard installation header",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah this was changed by accident. I think I told you to do this :) I can fix now 😊

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the great pair code and the work here, @henrikth93! 🚀🚀🚀🚀🚀🚀

@andrewtavis andrewtavis merged commit 5526c21 into scribe-org:main May 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants