Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

467 standardize app hints implementation to assure consistent locations #473

Conversation

Mashtaleralia
Copy link
Contributor

Contributor checklist


Description

Related issue

Copy link

github-actions bot commented Jul 3, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-iOS repo
  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review July 3, 2024 19:18
@andrewtavis
Copy link
Member

Hey @Mashtaleralia 👋 Thanks for the PR! Would be great to get a bit of a description for it, but then the change is quite apparent 😊 This is actually a good idea, that maybe the shift is being caused because the devices without a home button have a bit more of a distance from the top of the screen that needs to be accounted for (assuming given the change). Let me check it out and see if it's working :)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the clear solution here, @Mashtaleralia! Really appreciate the contribution, and I hope you join us in the public Matrix chat rooms 😊 Let us know if you have interest in anything else!

@andrewtavis andrewtavis merged commit 159dbf1 into scribe-org:main Jul 3, 2024
1 check passed
@Mashtaleralia
Copy link
Contributor Author

thanks!

@Mashtaleralia Mashtaleralia deleted the 467-standardize-app-hints-implementation-to-assure-consistent-locations branch July 4, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants