Polkadot v0.9.29 #282
Closed
Polkadot v0.9.29 #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haerdib
reviewed
Oct 21, 2022
There was a problem hiding this comment.
LGTM!
One remark: unlike all the other repositories, we keep the api-client master pointing to master branches of substrate. That's because multiple, independent projects are using this client.
So keep this branch as it is (polkadot-v0.9.29 should point to the equivalent substrate branch), but create a new PR with the same changes but with master branches. With
cargo update -p sp-core --precise COMMITHASH you should be able to choose a commit with the same level as the polkadot v0.9.29 branch)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
patch
ed25519-zebrafor no_std compatibility. See: paritytech/substrate#12225