-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
errors: rename and extract TracingError #1194
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See the following report for details: cargo semver-checks output
|
wprzytula
previously approved these changes
Feb 3, 2025
Lorak-mmk
previously approved these changes
Feb 3, 2025
@muzarski a rebase is needed. |
b58cabe
to
b1b4e9b
Compare
Rebased on main |
It was previously called `TracingProtocolError` and was contained in ExecutionError::ProtocolError. Since we now have a big picture of errors hierarchy, it's much clearer that `TracingError` should be a separate error type returned by tracing methods. ExecutionError should NOT depend on it. This commit renamed TracingProtocolError to TracingError, and changes the return type of Session::get_tracing_info(). New variant is introduced to `TracingError` - it contains an `ExecutionError`, which makes sense since we try to execute queries to system tracing tables.
b1b4e9b
to
a676f32
Compare
Rebased on main again (ssl CI fix, and removed legacy ser/deser api) |
Lorak-mmk
approved these changes
Feb 4, 2025
wprzytula
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
API-stability
Part of the effort to stabilize the API
semver-checks-breaking
cargo-semver-checks reports that this PR introduces breaking API changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #519
It was previously called
TracingProtocolError
and was contained in ExecutionError::ProtocolError.Since we now have a big picture of errors hierarchy, it's much clearer that
TracingError
should be a separate error type returned by tracing methods. ExecutionError should NOT depend on it.This PR renames TracingProtocolError to TracingError, and changes the return type of Session::get_tracing_info(). New variant is introduced to
TracingError
- it contains anExecutionError
, which makes sense since we try to execute queries to system tracing tables.Pre-review checklist
[ ] I added relevant tests for new features and bug fixes.[ ] I have adjusted the documentation in./docs/source/
.Fixes:
annotations to PR description.