Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hackathon schema agreement #1248

Open
wants to merge 4 commits into
base: branch-hackathon
Choose a base branch
from

Conversation

soyacz
Copy link

@soyacz soyacz commented Feb 14, 2025

Introduced 3 tests for schema agreement. based on 3 nodes cluster. Scenarios:

  1. all nodes up and normal, schema agreement should be ok
  2. one node is stopped, schema agreement should be ok
  3. one node is paused (not responding), schema agreement should be ok

3rd scenario currently fails due issue #1240

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

Copy link

github-actions bot commented Feb 14, 2025

cargo semver-checks found no API-breaking changes in this PR! 🎉🥳
Checked commit: 1e821ef

soyacz added 3 commits March 4, 2025 11:02
Tested scenarios (positive: schema agreement is ok):
1. when all nodes up
2. when one node is stopped
3. when one node is paused (looks like disconnected)
This way we save resources (less nodes) but prolong test duration (from
70 seconds to 90s, where 60s is lost on waiting for timeout in failing
 test)
@soyacz soyacz force-pushed the hackathon-schema-agreement branch from 23cb350 to 590866d Compare March 4, 2025 10:03
Make test easier to read and more robust.
@soyacz soyacz force-pushed the hackathon-schema-agreement branch from cb1d70a to 1e821ef Compare March 4, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant