Rework bitmap controls #2 #317
Conversation
olilarkin
force-pushed
the
rework-bitmap-controls
branch
from
6b44cb6 to
045b589
Compare
There was a problem hiding this comment.
Well, this isn't fun.
But, as I was reviewing this, I've realized that Ronduit is not a free font, which puts me in a tough spot wrt the open-source MIT license that this repo has.
One way to solve this would be to remove Ronduit from the PR. But, if you have any other ideas, I'm happy to hear them. But I don't feel comfortable accepting the PR without some change, unfortunately.
|
I was also dismayed to find that the font was not free after the graphics had been made previously based on a flattened photoshop file. I got the source photoshop file in order to create higher res resources, and only then found out the name of the font. But the license seems ok for NAM if it's open source and free. |
|
Better to include the license, obtain explicit permission from the author or change the font, IMO. It should be possible to find something suitable with a permissive license: |
Thanks for the suggestion Oli! Michroma looks fantastic to me as something in a similar style. In fact, I might even prefer it over Ronduit 🙂 You can change the PR, or I can probably handle it if you'd like; just let me know 👍🏻 |
olilarkin
force-pushed
the
rework-bitmap-controls
branch
from
045b589 to
279d04a
Compare
|
updated. Not 100% if it works on windows |
…/NeuralAmpModelerPlugin into rework-bitmap-controls
|
Should be good assuming it builds here |
@sdatkinson here is a new PR, commenting out the color picker and adapting the about box a bit
I really think it's better not to squash merge PRs, but to include a merge-commit. I try to make a big effort to make each commit clean and atomic, so that individual changes can be reverted, without reverting an entire PR.