Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to tokio 1.0 #72

Merged
merged 1 commit into from
Dec 30, 2020
Merged

Update to tokio 1.0 #72

merged 1 commit into from
Dec 30, 2020

Conversation

nickelc
Copy link
Contributor

@nickelc nickelc commented Dec 23, 2020

Draft until tokio-openssl, tokio-rustls and tokio-native-tls are ready.

@sdroege
Copy link
Owner

sdroege commented Dec 24, 2020

Thanks, I'll merge this once all the deps are on crates.io

@sdroege
Copy link
Owner

sdroege commented Dec 24, 2020

Also should wait for snapview/tungstenite-rs#163

@nickelc
Copy link
Contributor Author

nickelc commented Dec 24, 2020

Also should wait for snapview/tungstenite-rs#163

nice to have but it's not required.

@sdroege
Copy link
Owner

sdroege commented Dec 24, 2020

nice to have but it's not required.

True, it doesn't involve API changes in tungstenite :)

@nickelc nickelc marked this pull request as ready for review December 24, 2020 17:31
@sdroege sdroege merged commit 253f8c9 into sdroege:master Dec 30, 2020
@sdroege
Copy link
Owner

sdroege commented Dec 30, 2020

@nickelc Should we wait for the tungstenite release before releasing to crates.io or not? :)

@nickelc
Copy link
Contributor Author

nickelc commented Dec 30, 2020

@nickelc Should we wait for the tungstenite release before releasing to crates.io or not? :)

tungstenite release could happen in hours or days and i don't expect big changes beside bytes 1.0.
I think updating tungsteniste in a patch release should be fine and would unblock other projects sooner.

@nickelc nickelc deleted the tokio-1.0 branch December 30, 2020 12:40
@sdroege
Copy link
Owner

sdroege commented Dec 30, 2020

Let's do that then!

@sdroege
Copy link
Owner

sdroege commented Jan 8, 2021

Too bad, tungstenite was released as 0.12 now :)

@nickelc
Copy link
Contributor Author

nickelc commented Jan 8, 2021

Too bad, tungstenite was released as 0.12 now :)

But updating to 0.12 in patch version should be ok because it's not in public, right?
And tokio 1.0 already bumped the MSRV to 1.45.

@sdroege
Copy link
Owner

sdroege commented Jan 8, 2021

But updating to 0.12 in patch version should be ok because it's not in public, right?

Well, it is:

pub use tungstenite;

Anyway, not much of a problem. Just means yet another release :)

@nickelc
Copy link
Contributor Author

nickelc commented Jan 8, 2021

Well, it is:

pub use tungstenite;

my bad but 0.11 was fine. it unblocked a number of projects.

@sdroege
Copy link
Owner

sdroege commented Jan 8, 2021

Indeed :) I'll get a new release out some time later today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants