Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standalone-kernel: test install target #383

Merged
merged 1 commit into from
Mar 7, 2025
Merged

standalone-kernel: test install target #383

merged 1 commit into from
Mar 7, 2025

Conversation

lsf37
Copy link
Member

@lsf37 lsf37 commented Mar 2, 2025

Test cmake/ninja install target after compilation.

See also #382 and seL4/seL4#1338

Test cmake/ninja install target after compilation.

See also #382

Signed-off-by: Gerwin Klein <[email protected]>
@lsf37 lsf37 requested a review from kent-mcleod March 2, 2025 22:22
@lsf37 lsf37 added the seL4 actions on the kernel repo label Mar 2, 2025
Copy link
Contributor

@Indanz Indanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better than nothing, but it doesn't test whether the install directory actually contains what it should.

@lsf37
Copy link
Member Author

lsf37 commented Mar 2, 2025

It's better than nothing, but it doesn't test whether the install directory actually contains what it should.

That part should happen in the kernel repo (ideally as a part of the install step. but could be a separate target if we want), because the scripts here wouldn't know which files those should be. This step here just makes sure install is called so that the hook is there.

@lsf37 lsf37 merged commit aa48de8 into master Mar 7, 2025
7 checks passed
@lsf37 lsf37 deleted the test-install branch March 7, 2025 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
seL4 actions on the kernel repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants