Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Optimize code based on cargo clippy suggestions #2167

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: Optimize code based on cargo clippy suggestions #2167

wants to merge 1 commit into from

Conversation

tgolang
Copy link

@tgolang tgolang commented Mar 11, 2024

No description provided.

@tgolang
Copy link
Author

tgolang commented Apr 27, 2024

Anything need I to do? If have, Please feel free to tell me.

@seanmonstar
Copy link
Owner

The fmt job failed. Looking at your changes, you could undo many of the whitespace adjustments.

@tgolang
Copy link
Author

tgolang commented Apr 28, 2024

The fmt job failed. Looking at your changes, you could undo many of the whitespace adjustments.

Thanks. Modified

@tgolang
Copy link
Author

tgolang commented May 13, 2024

If anything need I to do, Please feel free to tell me.

@seanmonstar
Copy link
Owner

The CI errors show that the changes break the MSRV (minimum support Rust version).

@tgolang
Copy link
Author

tgolang commented Oct 6, 2024

The CI errors show that the changes break the MSRV (minimum support Rust version).

Thanks.

@tgolang
Copy link
Author

tgolang commented Mar 8, 2025

friendly ping~

@paolobarbolini
Copy link
Contributor

friendly ping~

You should rebase and see how the CI run goes

@tgolang
Copy link
Author

tgolang commented Mar 8, 2025

friendly ping~

You should rebase and see how the CI run goes

Thanks. Rebased.

I'll see if CI is completely passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tgolang @seanmonstar @paolobarbolini