SourceFilter test coverage #6148
Merged
+405
−223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantleech
force-pushed
the
gh-6114-source-filter-tests
branch
from
a40b4de to
c988cc2
Compare
dantleech
commented
Mar 14, 2025
dantleech
force-pushed
the
gh-6114-source-filter-tests
branch
2 times, most recently
from
b467bd6 to
a676cc7
Compare
- Extracts an `AbstractSouceFilterTestCase` as both SourceMapper and SourceFilter have the same requirements. - Refactor test to use factory methods to reduce boilerplate. - Introduces tests for wildcards, globstars and question marks.
dantleech
force-pushed
the
gh-6114-source-filter-tests
branch
from
a676cc7 to
b69ba97
Compare
dantleech
commented
Mar 14, 2025
| FileCollection::fromArray( | ||
| ), | ||
| ], | ||
| 'globstar with any more than a single char prefix does not include sibling files' => [ |
There was a problem hiding this comment.
this behavior (see test above too) is very strange. /<any char>** will be equivilent to /** but <more than 1 char>** will not
sebastianbergmann
added
type/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR aims to improve the test coverage for the SourceFilter in anticipation of #6146
AbstractSouceFilterTestCaseas both SourceMapper and SourceFilter have the same requirements.The tests are far from exhaustive as we are testing the behavior of
globin order to be able to avoid calling it in the future notably we are not testing character classes and all the variants therein - and it's an open question if PHPUnit should support that going forward? A quick scan of github doesn't reveal anybody making uses of character classes.