Feat/serde yml #11
Merged
Feat/serde yml #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nctions Changes based on @QuadnucYard PR - Changes based on master...QuadnucYard:serde_yml:relex-deps-radical
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11 +/- ##
==========================================
+ Coverage 66.82% 68.08% +1.25%
==========================================
Files 25 22 -3
Lines 2553 2500 -53
==========================================
- Hits 1706 1702 -4
+ Misses 847 798 -49 ☔ View full report in Codecov by Sentry. |
…::Document(doc)` etc
…tructuring a single pattern. Consider using `if let`
…nting the `Copy` trait to resolve Clippy warnings.
- Added tests to cover `parent`, `index`, and `key` fields in `Seq`, `Map`, `Alias`, and `Unknown` variants. - Verified correct formatting for nested and complex paths. - Adjusted `test_alias_with_parent` to account for the expected trailing period in the `Alias` variant. - Ensured logical ordering and coverage of edge cases in the tests. - Resolved Clippy warning by removing unnecessary `clone()` call in `test_path_clone_and_copy`.
…th handling - Added unit tests for various `Path` enum variants to ensure correct formatting and behavior: - `Path::Root` - `Path::Seq` - `Path::Map` - `Path::Alias` - `Path::Unknown` - Included tests for nested and complex path structures to verify deep nesting and parent-child relationships. - Added tests for handling special cases like large indices, empty keys, and different key types in `Path::Map`. - Implemented tests to ensure `Path` instances with identical structures are considered equal. - Verified correct behavior of the `Alias`, `Seq`, and `Map` variants when used as parents in nested paths. - Added tests to check proper panic behavior for unexpected end of sequence and mapping events. - Implemented a test for the `Alias` variant in the `Event` enum to ensure correct handling of alias indices.
- Organized and documented existing tests for Path enum variants (Root, Seq, Map, Alias, Unknown). - Added missing unit tests for: - Map variant with different key values (including empty key). - Seq variant with different index values. - Nested Path structures involving multiple variant combinations. - Ensured consistent docstrings and logical grouping of tests. - Included tests for: - Equality and cloning of Path instances. - Panic scenarios for unexpected sequence and mapping ends. - Handling of Alias variant in Event enum. - Improved coverage and robustness of test suite.
- Add new unit tests for `lib.rs` - Reorganized unit tests in a logical order - Added consistent docstrings to all test functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert!(true)will be optimized out by the compileris_none()matchfor destructuring a single pattern. Consider usingif letclonecalls for types implementing theCopytrait to resolve Clippy warnings.Progress::Document(doc)etc