RFE: support for SCMP_FLTATR_CTL_OPTIMIZE, SCMP_FLTATR_API_SYSRAWRC #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolyshkin
changed the title
kolyshkin
force-pushed
the
opt
branch
3 times, most recently
from
3bec561 to
94d13ad
Compare
|
Commit 23edf06 moved the SetBadArchAction(ActInvalid) check to the end of TestFilterAttributeGettersAndSetters. A few subsequent commits added more code before it, until finally commit 541420d added a conditional t.Skipf before it. As a result, this check is not performed with latest libseccomp. Move it back to where it belongs (before the API/version checks). Signed-off-by: Kir Kolyshkin <[email protected]>
1. Use checkAPI to check for minimal API level and libseccomp version requirements. 2. TestFilterAttributeGettersAndSetters tests multiple things, requiring different API levels and libseccomp versions. It should not use t.Skip in the middle of the test, since the end result is going to be "SKIP" instead of "PASS". In the middle of the test, use return to skip the part of the test. 3. While at it, don't use t.Logf/t.Errorf if there are no %-style arguments. Signed-off-by: Kir Kolyshkin <[email protected]>
Introduce (*ScmpFilter).GetOptimize and (*ScmpFilter).SetOptimize methods, together with the documentation and trivial tests. Signed-off-by: Kir Kolyshkin <[email protected]>
Introduce (*ScmpFilter).GetRawRC and (*ScmpFilter).SetRawRC methods, together with the documentation and trivial tests. Signed-off-by: Kir Kolyshkin <[email protected]>
|
No longer a draft |
pcmoore
approved these changes
Oct 28, 2021
There was a problem hiding this comment.
Looks good to me, @drakenclimber ?
Acked-by: Paul Moore <[email protected]>
drakenclimber
approved these changes
Oct 29, 2021
There was a problem hiding this comment.
Looks good to me, @kolyshkin. Thanks.
Acked-by: Tom Hromatka <[email protected]>
|
Merged at HEAD 460967f, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test fixups.
Those are fixups in test case used by the following commits.
Let me know if you want a separate PR for that (first two commits).
Add support for
SCMP_FLTATR_CTL_OPTIMIZEIntroduce
(*ScmpFilter).GetOptimizeand(*ScmpFilter).SetOptimizemethods, together with the documentation and trivial tests.
Add support for
SCMP_FLTATR_API_SYSRAWRCIntroduce
(*ScmpFilter).GetRawRCand(*ScmpFilter).SetRawRCmethods, together with the documentation and trivial tests.
Addresses: #37