Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sm2+fastecdlp #348

Merged
merged 13 commits into from
Jul 4, 2024
Merged

Sm2+fastecdlp #348

merged 13 commits into from
Jul 4, 2024

Conversation

ShallMate
Copy link
Contributor

No description provided.

@ShallMate
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@Jamie-Cui Jamie-Cui self-requested a review June 26, 2024 09:50
Jamie-Cui
Jamie-Cui approved these changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@Jamie-Cui Jamie-Cui left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

后续可能我们也会在内部对这部分代码进行一些修改，感谢贡献 @ShallMate

@Jamie-Cui Jamie-Cui self-requested a review July 1, 2024 03:10
Jamie-Cui
Jamie-Cui requested changes Jul 1, 2024
View reviewed changes
Jamie-Cui
Jamie-Cui requested changes Jul 1, 2024
View reviewed changes
@Jamie-Cui Jamie-Cui requested a review from shaojian-ant July 1, 2024 06:59
@ShallMate
Copy link
Contributor Author

我把文件夹的名字从大写改为了小写（与其他example保持一致），其余部分已经按您的要求进行了修改哈～。 @Jamie-Cui

@ShallMate ShallMate requested a review from Jamie-Cui July 2, 2024 10:02
Jamie-Cui
Jamie-Cui reviewed Jul 2, 2024
View reviewed changes
@ShallMate ShallMate requested a review from Jamie-Cui July 2, 2024 12:09
@ShallMate ShallMate requested a review from Jamie-Cui July 3, 2024 07:44
shaojian-ant
shaojian-ant reviewed Jul 3, 2024
View reviewed changes
@ShallMate ShallMate requested a review from shaojian-ant July 3, 2024 10:26
@Jamie-Cui
Copy link
Collaborator

我这边没有其他问题了，看 @shaojian-ant 那边 ok 的话就可以和入了

@shaojian-ant
Copy link
Collaborator

shaojian-ant commented Jul 4, 2024 •
edited
Loading

我这边也没有问题了 @Jamie-Cui

shaojian-ant
shaojian-ant approved these changes Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@shaojian-ant shaojian-ant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Jamie-Cui
Jamie-Cui approved these changes Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@Jamie-Cui Jamie-Cui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢 @ShallMate 的贡献，稍等这个 PR 我们会合入，再次感谢

@Jamie-Cui Jamie-Cui merged commit e230ae7 into secretflow:main Jul 4, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Jamie-Cui Jamie-Cui Jamie-Cui approved these changes

@shaojian-ant shaojian-ant shaojian-ant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShallMate @Jamie-Cui @shaojian-ant