Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!(examples): make examples a separate bazel project #408

Merged
merged 1 commit into from
Oct 19, 2024
Merged

refactor!(examples): make examples a separate bazel project #408

merged 1 commit into from
Oct 19, 2024

Conversation

Jamie-Cui
Copy link
Collaborator

@Jamie-Cui Jamie-Cui commented Oct 18, 2024

BREAKING CHANGE: yacl main project will not depends on pybind and jni_rules any more. Upstream applications should not reply on that.

@Jamie-Cui Jamie-Cui requested a review from anakinxc October 18, 2024 08:47
@Jamie-Cui Jamie-Cui changed the title repo-sync-2024-10-18T16:46:31+0800 refactor!(examples): make examples a separate bazel project Oct 18, 2024
@Jamie-Cui Jamie-Cui requested a review from a team October 18, 2024 08:56
Copy link
Collaborator

@tongke6 tongke6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jamie-Cui Jamie-Cui merged commit 18a346f into secretflow:main Oct 19, 2024
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants