Fix no-unused-vars false positive on for loops #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicaelRodrigues
added
bug
dependencies
MicaelRodrigues
force-pushed
the
bugfix/no-unused-vars-for-of
branch
2 times, most recently
from
905e589 to
738d9bd
Compare
MicaelRodrigues
force-pushed
the
bugfix/no-unused-vars-for-of
branch
2 times, most recently
from
dfc55d8 to
aee0093
Compare
bsonntag
approved these changes
Aug 24, 2022
bsonntag
force-pushed
the
bugfix/no-unused-vars-for-of
branch
from
aee0093 to
dd84009
Compare
This was referenced Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a eslint
false positivethat was triggeringno-unused-varserror on for loops.The issue is fixed by upgrading to
babel-eslintto latest (10.1.0) andeslintto last of 6 (6.8.0).Note: Support for
Node 8is also dropped in this version due tochakldependency: