-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UIK-3310]test for dependencies and import #1985
Merged
ilyabrower
merged 25 commits into
master
from
UIK-3310/test-for-dependencies---import-checks
Mar 13, 2025
Merged
[UIK-3310]test for dependencies and import #1985
ilyabrower
merged 25 commits into
master
from
UIK-3310/test-for-dependencies---import-checks
Mar 13, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f94ca32
to
a155631
Compare
… of github.com:semrush/intergalactic into UIK-3310/test-for-dependencies---import-checks
ilyabrower
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a shared step that gets all unique @semcore/.. imports and compares them with dependencies from package.json (i've excluded core because i noticed in some components that it presents in imports but absents in dependencies).
i left commented logs for debugging because it is very useful to debug locally when adding test in component.
Added this test for some packages
Motivation and Context
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist:
CHANGELOG.md
file with planned publish date.