Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UIK-3380][bulk-textarea] fixed tooltips if commonErrorMessage is empty #2013

Merged
merged 12 commits into from
Mar 6, 2025

Conversation

ilyabrower
Copy link
Contributor

Motivation and Context

How has this been tested?

Manually

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Nice improve.

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly or it's not required.
  • Unit tests are not broken.
  • I have added changelog note to corresponding CHANGELOG.md file with planned publish date.
  • I have added new unit tests on added of fixed functionality.

@ilyabrower ilyabrower self-assigned this Mar 4, 2025
Copy link
Contributor

@j-mnizhek j-mnizhek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's painful for me to see errors inside the input with no invalid state, but let's give them this opportunity
image

Finally I can add this pic to the PR
telegram-cloud-photo-size-4-6037264709004148724-y

@ilyabrower ilyabrower force-pushed the UIK-3380/bulk-textarea-no-common-errors branch from cd57021 to fb91b07 Compare March 5, 2025 12:28
@ilyabrower ilyabrower merged commit 145f1d7 into master Mar 6, 2025
9 checks passed
@ilyabrower ilyabrower deleted the UIK-3380/bulk-textarea-no-common-errors branch March 6, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants