Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UIK-3318][select] fixed defaultHighlightedIndex prop #2025

Merged

Conversation

ilyabrower
Copy link
Contributor

@ilyabrower ilyabrower commented Mar 13, 2025

Motivation and Context

I added logic about disabling highlightedIndex after opening by default by adding defaultHighlightedIndex=null

How has this been tested?

Manually + I added browser test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Nice improve.

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly or it's not required.
  • Unit tests are not broken.
  • I have added changelog note to corresponding CHANGELOG.md file with planned publish date.
  • I have added new unit tests on added of fixed functionality.

@ilyabrower ilyabrower self-assigned this Mar 13, 2025
Copy link
Contributor

@sheila-semrush sheila-semrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I don't have any additional comments, apart from what Valeria wrote in the task. Noticed some screen reader issues, created a separate task for that.

@Valeria-Zimnitskaya Valeria-Zimnitskaya merged commit 762430c into master Mar 14, 2025
9 checks passed
@Valeria-Zimnitskaya Valeria-Zimnitskaya deleted the UIK-3318/default-highlighted-index-in-select branch March 14, 2025 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants