ARs and Samples from other clients are listed when logged in as contact #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although Client contacts cannot access to Analysis Requests from other clients (Unauthorized traceback is rised), they could still see them in lists. With this commit, we guarantee that ARs from clients other than the contact are never displayed.
Although Client contacts cannot access to Samples from other clients (Unauthorized traceback is rised), they could still see them in lists. With this commit, we guarantee that Samples from clients other than the contact are never displayed.
xispa
changed the title
ramonski
approved these changes
Aug 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
Although Client contacts cannot access to Analysis Requests or Sampels from other clients (Unauthorized traceback is rised), they could still see them in lists. This commit enforces to never list Analysis Requests and Samples from clients other than the contact.
Current behavior before PR
Analysis Requests and Samples from clients other than current contact are displayed in listings.
Desired behavior after PR is merged
Analysis Requests and Samples from clients other than current contact are not displayed in listings.
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.