Improved Email Publication #1413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonski
added
Improvement 🔧
P3: Important
Cleanup 🧹
This fixes this traceback when coming from senaite.impress: Traceback (innermost last): Module ZPublisher.Publish, line 138, in publish Module ZPublisher.mapply, line 77, in mapply Module ZPublisher.Publish, line 48, in call_object Module bika.lims.browser.publish.emailview, line 71, in call Module plone.protect.authenticator, line 82, in check Forbidden: Form authenticator is invalid.
This fixes lookup issues with LDAP users
xispa
approved these changes
Jul 30, 2019
| elif isinstance(filedata, (file, StringIO)): | ||
| data = filedata.read() | ||
| # Handle file paths | ||
| if is_file(filedata): |
|
Give me 2d or so to definitely merge this into master. I'd like to ensure compatibility with other add-ons first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
This PR improves the email publication view with the primary focus to avoid multiple email submissions when DB conflicts occur during sample publication.
Current behavior before PR
Desired behavior after PR is merged
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.