Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscriber adapters not supported in clients listing #1418

Merged
merged 4 commits into from
Aug 9, 2019
Merged

Subscriber adapters not supported in clients listing #1418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
131d271
Subscriber adapters for ClientFolder view was not working
xispa Aug 8, 2019
7be8524
Changelog
xispa Aug 8, 2019
f2c7190
Use super and remove unnecessary call to super in folderitem
xispa Aug 9, 2019
0f48aeb
Merge branch 'master' into client-folder-adapters
xispa Aug 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ Changelog

**Fixed**

- #1418 Subscriber adapters not supported in clients listing
- #1419 Mixed permissions for transitions in client workflow
- #1414 Occasional "OSError: [Errno 24] Too many open files" in frontpage

Expand Down
4 changes: 4 additions & 0 deletions bika/lims/browser/clientfolder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,9 @@ def __init__(self, context, request):
def before_render(self):
"""Before template render hook
"""
# Call `before_render` from the base class
super(ClientFolderContentsView, self).before_render()

# Render the Add button if the user has the AddClient permission
if check_permission(AddClient, self.context):
self.context_actions[_("Add")] = {
Expand Down Expand Up @@ -181,6 +184,7 @@ def folderitem(self, obj, item, index):
phone = obj.getPhone()
if phone:
item["replace"]["Phone"] = get_link("tel:{}".format(phone), phone)

return item


Expand Down