Allow to detach a partition from its primary sample #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
This Pull Requests adds an additional transition "detach", only available for Partitions. This transition makes the partition to be detached from the primary, so is no longer a "real-partition". Thus, a detached partition behaves like a Primary Sample and the original primary sample no longer follows the status of the detached partition. Nevertheless, the system keeps track of that relationship and displays a message informing the user about that ancestry.
Current behavior before PR
Partitions cannot be detached from their primary sample, that in turn, follows the workflow of its partitions
Desired behavior after PR is merged
Partitions can be detached from their primary sample, but without losing their ancestry relatonship
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.