Notify user with failing addresses when emailing of results reports #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonski
reviewed
Aug 13, 2019
| @@ -510,7 +510,9 @@ def send_email(self, recipients, subject, body, attachments=None): | |||
| attachments=attachments) | |||
| sent = mailapi.send_email(mime_msg) | |||
| if not sent: | |||
| logger.error("Could not send email to {}".format(pair)) | |||
| msg = "Could not send email to {}".format(pair) | |||
There was a problem hiding this comment.
I'm just wondering if this message also works for email, name pairs which contain unicode characters. Can you try that please with a recipient name that contains unicode characters?
There was a problem hiding this comment.
Thanks for the heads-up!. Just added this commit:
077dd13
And this is what I get when using pairs containing unicode chars:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
Notifies the user with the unsuccessful email addresses when emailing results reports.
Linked issue: #1423
Current behavior before PR
User receives a warning stating "Failed to send Email(s)", but without any further information
Desired behavior after PR is merged
User receives the same warning as above, plus the list of addresses for which the emailing failed
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.