Publish verified partitions #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xispa
requested changes
Sep 3, 2019
|
|
||
| def publish(self, sample): | ||
| """Set status to prepublished/published/republished | ||
| """ | ||
| # publish partitions | ||
| for partition in sample.getDescendants(): | ||
| self.publish(partition) |
There was a problem hiding this comment.
To keep the code consistent regarding transitions, I think it would be better to add a function def after_prepublish in workflow.analysisrequest.events instead of publishing the descendants one by one here. This after_prepublish transition might look similar to after_publish funciton:
def after_prepublish(analysis_request):
do_action_to_descendants(analysis_request, "publish")
bika/lims/browser/workflow/client.py
Outdated
| @@ -54,6 +54,9 @@ def get_sample_uids_in_report(self, report): | |||
| def publish_sample(self, sample): | |||
| """Set status to prepublished/published/republished | |||
| """ | |||
| # publish partitions | |||
| for partition in sample.getDescendants(): | |||
| self.publish_sample(partition) | |||
…ite.core into partition-publication
xispa
approved these changes
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
This PR changes the primary sample publication behaviour, so that verified partitions are transitioned to the publish state if they were in verified state before.
Current behavior before PR
If a primary sample with descendants (partitions) is pre-published, none of the verified partitions is published.
Desired behavior after PR is merged
If a primary sample with descendants (partitions) is pre-published, all of the verified partitions are published.
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.