Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add2: Do not set template values on already filled fields #1429

Merged
merged 3 commits into from
Sep 3, 2019

Conversation

ramonski
Copy link
Contributor

Description of the issue/feature this PR addresses

This PR changes the behavior of templates in the Add view

Current behavior before PR

Template values always overwrite copied values in the Add view

Desired behavior after PR is merged

Template values only get set if the field was previously empty

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@ramonski ramonski requested a review from xispa August 23, 2019 20:13
@xispa xispa merged commit 0606d79 into master Sep 3, 2019
@xispa xispa deleted the add2-avoid-template-overwrites branch September 3, 2019 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants