Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Identifier Types #1430

Merged
merged 18 commits into from
Oct 7, 2019
Merged

Removed Identifier Types #1430

merged 18 commits into from
Oct 7, 2019

Conversation

ramonski
Copy link
Contributor

Description of the issue/feature this PR addresses

Linked issue: #1416

Current behavior before PR

Identifiers part of senaite.core

Desired behavior after PR is merged

Identifiers no longer part of senaite.core

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@ramonski ramonski added P3: Important Cleanup 🧹 Code cleanup and refactoring labels Aug 24, 2019
@ramonski ramonski requested a review from xispa August 24, 2019 20:23
@ramonski ramonski changed the title Remove Identifiers Removed Identifiers Aug 24, 2019
@xispa
Copy link
Member

xispa commented Sep 3, 2019

senaite.health makes use of IdentifierType content type for Patient:
https://github.com/senaite/senaite.health/blob/1f4d8f751b6ee4c218b46d96135a853095b558f6/bika/health/content/patient.py#L170-L208

Thus, this change needs to be considered in senaite.health before being merged. Otherwise, pre-existing Identifier types set for patients might be lost. Will do the proper changes in senaite.health to ensure compatibility with this one and will review and eventually merge thereafter.

@xispa xispa self-assigned this Sep 3, 2019
@xispa xispa changed the title Removed Identifiers Removed Identifier Types Oct 7, 2019
@xispa xispa merged commit 9f75f83 into master Oct 7, 2019
@xispa xispa deleted the i1416-remove-identifiers branch October 7, 2019 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup 🧹 Code cleanup and refactoring P3: Important
Development

Successfully merging this pull request may close these issues.

2 participants