Setting in setup for auto-reception of samples upon creation #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonski
reviewed
Sep 9, 2019
| # Auto-receive samples is enabled. Receive the sample automatically, | ||
| # but only if the current user is a laboratory contact | ||
| user = api.get_current_user() | ||
| contact = api.get_user_contact(user, contact_types=["LabContact"]) |
There was a problem hiding this comment.
Wouldn't it be better here to check the role of the user? E.g. if the user has the permission to receive the sample?
There was a problem hiding this comment.
OMG, you're totally right!. Thanks for pointing this out.
There was a problem hiding this comment.
Also consider to cache the user role in the request in case of multi-reception. Not sure how "expensive" the role lookup is in terms of performance...
There was a problem hiding this comment.
To handle exceptions, I suggest making an option with this setting as default in the sample add form.
ramonski
approved these changes
Sep 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
By default, the samples need to be received by lab personnel after they are created in the system. Quite often, lab personnel would like the samples that are created by themselves to be automatically received.
Current behavior before PR
Samples created by lab personnel cannot be auto-received upon creation
Desired behavior after PR is merged
Samples created by lab personnel can be auto-received upon creation
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.