Workflow refactoring: publish #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The publish transition can only be performed at Analysis Request level. Since getEarliness, getDuration and getDatePublished functions have been moved to AbstractAnalysis/AbstractRoutineAnalysis, and promoting the "publish" transition to parent Analysis Request doesn't make sense, the after_publish event binded to analysis is no longer needed.
Leave the guard and conditions set in the DC Workflow for analysis objects to be in charge of checking if an analysis with a given state can be transitioned to publish or not.
There are no longer required, functions have been added
Since the event.after_publish has been removed, this is not longer needed
Ruhanga
pushed a commit
to Ruhanga/senaite.core
that referenced
this pull request
Mar 14, 2022
Additional identifiers for Patients ported to senaite.health
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workflow for publish revisited, as well as other minor improvements, specially regarding to Duration and Earliness fields from Analysis.
Also note that a new upgradestep (1707) has been added, cause there was the need to change the expression for the 'publish' guard in bika_ar_workflow