Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameter group in contact._addUserToGroup was not considered #1446

Merged
merged 1 commit into from
Sep 24, 2019
Merged

Parameter group in contact._addUserToGroup was not considered #1446

merged 1 commit into from
Sep 24, 2019

Conversation

xispa
Copy link
Member

@xispa xispa commented Sep 23, 2019

Description of the issue/feature this PR addresses

The parameter group from function _addUserToGroup from Contact was not being used, so "Clients" was the group always assigned to the contact.

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@xispa xispa requested a review from ramonski September 23, 2019 21:01
ramonski
ramonski approved these changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@ramonski ramonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@ramonski ramonski merged commit 9491368 into master Sep 24, 2019
@ramonski ramonski deleted the fix-add-user-to-group branch September 24, 2019 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramonski ramonski ramonski approved these changes

Assignees
No one assigned
Labels
Bug 🐞 P3: Important
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xispa @ramonski