Fix initial IDs not starting with 1 #1453
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
When the ID Server does not find the generated key in its storage, e.g. for Sample Conditions the key
samplecondition
, it tries to handle the case when the storage was flushed and searches for all objects starting with this prefix.Unfortunately, the temporary generated ID of the current context is there included, e.g.
samplecondition.2019-10-10.5905228809
and the sequence number returns10
in that case.PDB Excerpt from https://github.com/senaite/senaite.core/blob/master/bika/lims/idserver.py#L457:
Current behavior before PR
Initial IDs started with the sequence 11
Desired behavior after PR is merged
Initial IDs start with the sequence 1
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.