Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unassign transition for cancelled/rejected/retracted analyses #1461

Merged
merged 5 commits into from
Oct 17, 2019

Conversation

ramonski
Copy link
Contributor

Description of the issue/feature this PR addresses

When assigned analyses are cancelled/rejected/retracted, they remain in the Worksheet.
If these were the only Analyses in the Worksheet, the Worksheet is stuck in Open state

Current behavior before PR

Analyses in the states cancelled, rejected or retracted can not be removed from worksheets which keeps the worksheet stuck in open state.

Desired behavior after PR is merged

Analyses in the states cancelled, rejected or retracted can be removed from worksheets. The worksheet can be removed afterwards.

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@xispa xispa merged commit c961409 into master Oct 17, 2019
@xispa xispa deleted the allow-unassign-transition branch October 17, 2019 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants