Cannot override behavior of Batch folder when using before_render
#1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
senaite.core's BatchFolder is used as the "root" listing view for batches listings. Nevertheless, it overrides the functionbefore_render. As a result, some of the changes made in subscriber adapters from another add-ons are omitted. For instance, trying to modifycontext_actionsvia subscriber adapters won't have any effect because after the call, the value is overriden in BatchFolder.This Pull Request, moves the logic for
before_renderfrom the base class "BatchFolder" to the functionupdate.Current behavior before PR
Cannot override some behavior (e.g.,
context_actions) of BatchFolder listing by using subscriber adapters.Desired behavior after PR is merged
Can override behavior of BatchFolder listoing by using subscriber adapters.
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.