Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Site Properties Generic Setup Export Step #1469

Merged
merged 4 commits into from
Nov 10, 2019

Conversation

ramonski
Copy link
Contributor

@ramonski ramonski commented Nov 8, 2019

Description of the issue/feature this PR addresses

This PR fixes the Site Properties Generic Setup Export Step:
Products.CMFCore.exportimport.properties.exportSiteProperties

This issue was introduced by the Structure Export/Import functionality of #1463

Current behavior before PR

The SenaiteSiteXMLAdapter was called by Products.CMFCore.exportimport.properties.exportSiteProperties

Desired behavior after PR is merged

The correct adapter is called by Products.CMFCore.exportimport.properties.exportSiteProperties

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@ramonski ramonski requested a review from xispa November 8, 2019 21:22
@ramonski ramonski changed the title Explicitly instantiate Senaite Site Adapter Fix Site Properties Generic Setup Export Step Nov 8, 2019
Copy link
Member

@xispa xispa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested and AttributeError: email_from_name does no longer happen. Thanks!

@xispa xispa merged commit 79e6408 into master Nov 10, 2019
@xispa xispa deleted the fix-generic-setup-adapter-clash branch November 10, 2019 11:26
@whoami-ap
Copy link

Hi @xispa i'm new of this stuff (Git, Senaite) and i'm sorry for my stupid question.
I follow this guide https://www.senaite.com/docs/installation.html to get senaite, but occurs AttributeError: email_from_name error. I understood that you have not this problem anymore, how can i do?
I have tried to modify the files as @ramonski suggests and i have created the v01_03_003.py file from new because wasn't in my folder at this point -> bin/bildout and bin/instance fg(start) but the error is still there.

@xispa
Copy link
Member

xispa commented Feb 19, 2020

@whoami-ap try the following:

  1. Login as admin user
  2. Go to Site Setup > Zope Management Interface
  3. Click to portal_setup (Add-on and configuration management)
  4. Click to Advanced Import tab (top)
  5. Choose "SENAITE Core" from the first selection list (Selection of a profile by title)
  6. Check 39 Plone Properties
  7. Press Import selected steps button (bottom of the list)

@whoami-ap
Copy link

@whoami-ap try the following:

1. Login as admin user

2. Go to _Site Setup > Zope Management Interface_

3. Click to _portal_setup (Add-on and configuration management)_

4. Click to _Advanced Import_ tab (top)

5. Choose "SENAITE Core" from the first selection list (_Selection of a profile by title_)

6. Check _39 Plone Properties_

7. Press _Import selected steps_ button (bottom of the list)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants