Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secondary samples - removal of analysis profile not possible #1472

Merged
merged 1 commit into from
Nov 22, 2019
Merged

Conversation

xispa
Copy link
Member

@xispa xispa commented Nov 22, 2019

Description of the issue/feature this PR addresses

When a Primary Sample is selected in Add form, some fields are automatically populated with the values coming from the Primary. Although this is the desirable behavior for most of the fields, some of the fields should remain unset to allow user to change their value at will. With this Pull Request, the values for the following fields are not set automatically when a Primary is selected:

  • Profiles
  • Template
  • Specification
  • Preservation

Linked issue: #1471

Current behavior before PR

User cannot edit the profiles when a Primary is selected

Desired behavior after PR is merged

User can edit the profiles when a Primary is selected

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@xispa xispa requested a review from ramonski November 22, 2019 08:45
@xispa xispa added the Bug 🐞 label Nov 22, 2019
Copy link
Contributor

@ramonski ramonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this one!

@ramonski ramonski merged commit b63a295 into master Nov 22, 2019
@ramonski ramonski deleted the i1471 branch November 22, 2019 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants