Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden settings of analysis services lost on Sample creation #1473

Merged
merged 2 commits into from
Nov 22, 2019
Merged

Conversation

xispa
Copy link
Member

@xispa xispa commented Nov 22, 2019

Description of the issue/feature this PR addresses

When Profiles and/or Templates are selected on Sample add form, "hidden" settings for analyses services are not populated in the newly created sample.

Linked issues:

Current behavior before PR

"hidden" settings for analysis services from profiles and/or templates are not populated in sample

Desired behavior after PR is merged

"hidden" settings for analysis services from profiles and/or templates are populated in sample

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@xispa xispa added the Bug 🐞 label Nov 22, 2019
@xispa xispa requested a review from ramonski November 22, 2019 09:56
Copy link
Contributor

@ramonski ramonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ramonski ramonski merged commit c1cdbe3 into master Nov 22, 2019
@ramonski ramonski deleted the i1437 branch November 22, 2019 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants