Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clients default CC E-Mails missing in Add Sample #1478

Merged
merged 4 commits into from
Nov 27, 2019
Merged

Clients default CC E-Mails missing in Add Sample #1478

merged 4 commits into from
Nov 27, 2019

Conversation

xispa
Copy link
Member

@xispa xispa commented Nov 26, 2019

Description of the issue/feature this PR addresses

Linked issue: #1406

Current behavior before PR

CCEmails field in Add Sample does not get populated once a Client with a value for this setting is selected

Desired behavior after PR is merged

CCEmails field in Add Sample does get populated once a Client with a value for this setting is selected

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@xispa xispa added the Bug 🐞 label Nov 26, 2019
@xispa xispa requested a review from ramonski November 26, 2019 10:23
Copy link
Contributor

@ramonski ramonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for removing that AcquireFieldDefaults adapter!

@ramonski ramonski merged commit f42093e into master Nov 27, 2019
@ramonski ramonski deleted the i1406 branch November 27, 2019 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants