Error: Labclerks viewing verified worksheets #1479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The permissions for manage_results view were wrong. EditWorksheet permission makes sense in views that are used for adding analyses, etc. (e.g. AddDuplicates, Add Control, etc.), but the permission for analyses listing (manage_results) in Worksheet should be govened by ViewResults only. If the current status of the analysis does not allow its edition for the current user, this is handled automatically by folderitems, so there is no sense to apply the permission for EditWorksheet at this lsiting level.
ramonski
approved these changes
Nov 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
The permissions for manage_results view were wrong.
EditWorksheetpermission makes sense in views that are used for adding analyses, etc. (e.g. AddDuplicates, Add Control, etc.), but the permission for analyses listing (manage_results) in Worksheet should be govened byViewResultsonly.If the current status of the analysis does not allow its edition for the current user, this is handled automatically by folderitems, so there is no sense to apply the permission for
EditWorksheetat this lsiting level.Linked issue: #1396
Current behavior before PR
User with labclerk role cannot access to verified Worksheets
Desired behavior after PR is merged
User with labclerk role can access to verified Worksheets
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.