Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worksheet removal results in 404 #1480

Merged
merged 1 commit into from
Nov 27, 2019
Merged

Worksheet removal results in 404 #1480

merged 1 commit into from
Nov 27, 2019

Conversation

xispa
Copy link
Member

@xispa xispa commented Nov 26, 2019

Description of the issue/feature this PR addresses

Linked issue: #1322

Current behavior before PR

A "page not found" is displayed after "Remove" action is clicked inside Worksheet context

Desired behavior after PR is merged

The worksheets listing is displayed after "Remove" action is clicked inside Worksheet context

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@xispa xispa added the Bug 🐞 label Nov 26, 2019
@xispa xispa requested a review from ramonski November 26, 2019 13:53
Copy link
Contributor

@ramonski ramonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly and I wasn't aware that this portal_form_controller tool is still used.

@ramonski ramonski merged commit 51760a5 into master Nov 27, 2019
@ramonski ramonski deleted the i1322 branch November 27, 2019 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants