Fix KeyError in Sample Type Listing #1494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix KeyError when some subfields of the retention period are omitted. Traceback (innermost last): Module ZPublisher.Publish, line 138, in publish Module ZPublisher.mapply, line 77, in mapply Module ZPublisher.Publish, line 48, in call_object Module senaite.core.listing.view, line 222, in __call__ Module senaite.core.listing.ajax, line 101, in handle_subpath Module senaite.core.listing.decorators, line 63, in wrapper Module senaite.core.listing.decorators, line 50, in wrapper Module senaite.core.listing.decorators, line 100, in wrapper Module senaite.core.listing.ajax, line 533, in ajax_folderitems Module senaite.core.listing.decorators, line 88, in wrapper Module senaite.core.listing.ajax, line 305, in get_folderitems Module senaite.core.listing.view, line 837, in folderitems Module bika.lims, line 224, in wrapper Module senaite.core.listing.view, line 1143, in _folderitems Module bika.lims.controlpanel.bika_sampletypes, line 157, in folderitem KeyError: 'minutes'
xispa
approved these changes
Dec 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
This PR fixes a KeyError when some subfields of the retention period are omitted.
Traceback:
Current behavior before PR
Traceback occurs when not all values of the retention period were set
Desired behavior after PR is merged
No traceback happens and omitted fields default to 0
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.