Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage Analyses Form re-applies partitioned Analyses back to the Root Sample #1505

Merged
merged 24 commits into from
Jan 17, 2020

Conversation

ramonski
Copy link
Contributor

Description of the issue/feature this PR addresses

Linked issue: #1504

Current behavior before PR

Root Sample contains Analyses that are assigned to one of its partitions due to improper handling of the Sample Analyses Field

Desired behavior after PR is merged

Root Sample contains no Analyses that are assigned to one of tis partitions and the Sample Analysis Field handles Analyses of Partitions properly

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@xispa xispa changed the title Fix cascaded Analyses in Root Samples Manage Analyses Form re-applies partitioned Analyses back to the Root Sample Jan 17, 2020
Copy link
Member

@xispa xispa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@xispa xispa merged commit 257903b into master Jan 17, 2020
@xispa xispa deleted the fix-cascaded-root-analyses branch January 17, 2020 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants