Support for semi-colon character separator in CCEmails field #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xispa
changed the title
ramonski
approved these changes
Jan 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
In quite often applications, e-mails are separated with semi-colon ";" character, but in reports listing and email view, only comma "," character is supported. Thus, if the user copy&paste emails from any other application when filling the CCEmail in Sample view, the generation of the email view won't consider them as a list of emails and the email won't be received by those recipients.
Current behavior before PR
Semi-colon character (";") not supported on CCEmails field
Desired behavior after PR is merged
Semi-colon character (";") supported on CCEmails field
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.