Do not try to render InstrumentQCFailuresViewlet to non-lab personnel #1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
Although the viewlet
InstrumentQCFailuresViewletwon't be displayed to non-lab personnel (because they don't have privileges to search forInstrumentsfromsetup, the system tries to render the viewlet still. This makes anUnauthorizederror to rise up in logs and also makes the rendering of the current context slower.Current behavior before PR
System tries to render the viewlet
InstrumentQCFailuresViewletfor non-lab usersDesired behavior after PR is merged
System does not even try to render the viewlet.
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.