QC Analyses listing appears empty in Sample view #1512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonski
reviewed
Jan 28, 2020
| }) | ||
|
|
||
| # Add Worksheet and QC Sample ID columns | ||
| new_columns = OrderedDict(( |
There was a problem hiding this comment.
I would do it the other way around. Put this into the __init__ and flush it eventually when there are no QC analyses in update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
When QC Analyses (controls, blanks, duplicates) are added in a worksheet, they should be listed in QC Analyses section from inside Sample view if the worksheet contains at least one analysis of the latter.
Current behavior before PR
QC Analyses listing appears empty
Desired behavior after PR is merged
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.