Consider analyses with result options or string result in duplicate valid range #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xispa
changed the title
ramonski
approved these changes
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
The calculation of valid range for a given duplicate does not take into consideration when the original analysis has results options or string result enabled. Rather, it applies same algorithm used for when result is numeric (% of duplicate variation).
This pull request guarantees that when the original analysis has result options enabled or its result is a non-numeric value, the expected result for duplicate is an exact match and the duplicate variation is not used.
Current behavior before PR
Analyses with results range options or string result are not considered in duplicate's valid range
Desired behavior after PR is merged
Analyses with results range options or string result are considered in duplicate's valid range
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.