Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScripts/CSS Integration and Cleanup #1520

Merged
merged 13 commits into from
Feb 7, 2020
Merged

JavaScripts/CSS Integration and Cleanup #1520

merged 13 commits into from
Feb 7, 2020

Conversation

ramonski
Copy link
Contributor

@ramonski ramonski commented Feb 6, 2020

Description of the issue/feature this PR addresses

This PR moves all JS/CSS resources from senaite.lims -> senaite.core.
Furthermore, several JS/CSS files have been replaced with the minimized versions to increase loading speed. Also unused JS/CSS registries have been disabled.

Current behavior before PR

JS/CSS registered in senaite.lims and senaite.core

Desired behavior after PR is merged

JS/CSS only registered and maintained in senaite.core

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@ramonski ramonski requested a review from xispa February 6, 2020 21:40
@ramonski ramonski added Cleanup 🧹 Code cleanup and refactoring Addition ➕ labels Feb 6, 2020
Copy link
Member

@xispa xispa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@xispa xispa merged commit cac8649 into master Feb 7, 2020
@xispa xispa deleted the javascripts branch February 7, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Addition ➕ Cleanup 🧹 Code cleanup and refactoring
Development

Successfully merging this pull request may close these issues.

2 participants