Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wrong placement of ajax timeout option #1524

Merged
merged 1 commit into from
Feb 9, 2020
Merged

Conversation

ramonski
Copy link
Contributor

@ramonski ramonski commented Feb 9, 2020

Description of the issue/feature this PR addresses

Fix regression introduced in #1522 by placing the jQuery ajax timout option at the wrong place

Current behavior before PR

Traceback occurs:

Traceback (most recent call last):
  File "/Users/rbartl/.buildout/eggs/plone.jsonapi.core-0.6-py2.7.egg/plone/jsonapi/core/browser/decorators.py", line 24, in decorator
    return f(*args, **kwargs)
  File "/Users/rbartl/.buildout/eggs/plone.jsonapi.core-0.6-py2.7.egg/plone/jsonapi/core/browser/api.py", line 60, in to_json
    return self.dispatch()
  File "/Users/rbartl/.buildout/eggs/plone.jsonapi.core-0.6-py2.7.egg/plone/jsonapi/core/browser/api.py", line 54, in dispatch
    return router(self.context, self.request, path)
  File "/Users/rbartl/.buildout/eggs/plone.jsonapi.core-0.6-py2.7.egg/plone/jsonapi/core/browser/router.py", line 138, in __call__
    return self.view_functions[endpoint](context, request, **values)
  File "/Users/rbartl/develop/ridingbytes/bechem/bechem.lims/src/senaite.core/bika/lims/jsonapi/update.py", line 162, in update
    raise BadRequest("The following request fields were not used: %s.  Request aborted." % self.unused)
BadRequest: The following request fields were not used: ['timeout'].  Request aborted.

Desired behavior after PR is merged

No traceback occurs

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@ramonski ramonski requested a review from xispa February 9, 2020 22:25
@xispa xispa merged commit e177167 into master Feb 9, 2020
@xispa xispa deleted the fix-remarks-ajax-timeout branch February 9, 2020 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants