Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated jQuery Barcode to version 2.2.0 #1532

Merged
merged 4 commits into from
Feb 12, 2020
Merged

Updated jQuery Barcode to version 2.2.0 #1532

merged 4 commits into from
Feb 12, 2020

Conversation

ramonski
Copy link
Contributor

Description of the issue/feature this PR addresses

This PR updates jQuery Barcode from version 2.0.2 to version 2.2.0.
Furthermore, it uses the minimized version and safes therefore ~26K per request

Changelog

2.2.0 - 2019-02-21
fix svg on latest chrome
refactor for get latest minified code

2.1.0 - 2014-04-15
fix missing declarations
refactor code

2.0.3 - 2013-01-06
remove useless code from datamatrix
add upc support (Niels Leenheer)

2.0.2 - 2011-03-01
integration to jquery updated
table B of code 128 fixed (\ instead of ) thanks to jmcarson

Current behavior before PR

Unminified jQuery Barcode 2.0.2 was used

Desired behavior after PR is merged

Minified jQuery Barcode 2.2.0 is used

I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@ramonski ramonski added Improvement 🔧 Cleanup 🧹 Code cleanup and refactoring labels Feb 11, 2020
@ramonski ramonski requested a review from xispa February 11, 2020 22:04
@xispa xispa merged commit f6a24ca into master Feb 12, 2020
@xispa xispa deleted the jquery-barcode branch February 12, 2020 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup 🧹 Code cleanup and refactoring Improvement 🔧
Development

Successfully merging this pull request may close these issues.

2 participants